A few prep patches for https://github.com/bootc-dev/bootc/pull/2290 - #2454
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The repository-wide runner migration and command-capture change require completed CI and final human validation.
Pull request overview
Prepares CI and test infrastructure for PR #2290.
Changes:
- Captures command output with
memfd. - Migrates CI to Ubuntu 26.04 and pins Python 3.12.
- Applies boot context during TMT plan discovery.
File summaries
| File | Description |
|---|---|
.github/actions/install-tmt/action.yml |
Configures Python 3.12 for TMT. |
.github/workflows/ci.yml |
Migrates CI jobs to Ubuntu 26.04. |
crates/utils/Cargo.toml |
Moves tempfile to development dependencies. |
crates/utils/src/command.rs |
Replaces temporary output files with memfd. |
crates/xtask/src/tmt.rs |
Adds context-aware TMT plan discovery. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
In what turns out to be a GIANT trap, systemd generators on RHEL9 may run before a writable /tmp is available. Assisted-by: https://github.com/cgwalters/cgwalters#llms Signed-off-by: Colin Walters <walters@verbum.org>
Use the native QEMU stack containing the virtiofs notifier-ordering fix, rather than mixing newer emulator packages into an older runner. Keep TMT on the Python 3.12 runtime used for validation. Requires Ubuntu setup to select the native QEMU package on 26.04. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
FMF adjustments need the boot type and seal state during plan discovery, not only during execution. Honor disabled plans before provisioning a VM so unsupported test variants can be excluded through existing metadata. Keep an unspecified seal state distinct from an explicitly unsealed one. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
prep-2290
branch
from
September 11, 2026 20:32
fb13759 to
12f03a0
Compare
Collaborator
Author
|
OK, looks like something going wrong with libvirt firmware selection. |
gursewak1997
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big one is moving CI to 26.04, see bootc-dev/actions#53 which tries to hack around this on 24.04 but it really feels cleaner to just jump straight to 26.04.