imageproxy: introduce SkopeoSpawnError to improve UX #73
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
changed the title
This commit adds a new SkopeoSpawnError that helps with tweaking the user-experience when e.g. skopeo is not installed. Partially closes: containers/composefs-rs#59 Signed-off-by: Michael Vogt <[email protected]>
mvo5
force-pushed
the
new-SkopeoSpawnError
branch
from
04099df to
8f992d3
Compare
allisonkarlitskaya
approved these changes
Jan 17, 2025
|
Agreed this is great! I had just one minor test followup in #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new SkopeoSpawnError that helps with tweaking the user-experience when e.g. skopeo is not installed.
Partially closes:
containers/composefs-rs#59