Skip to content

client: Handle get_blob futures being polled serially #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

client: Handle get_blob futures being polled serially #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5c34b
examples: Drop accidentally committed dbg!
cgwalters Apr 4, 2025
c8ebd96
client: Add documentation for handling dual futures
cgwalters Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ async fn fetch_container_to_devnull(o: GetMetadataOpts) -> Result<()> {
let mut devnull = tokio::io::sink();
let copier = tokio::io::copy(&mut blob, &mut devnull);
let (copier, driver) = tokio::join!(copier, driver);
dbg!(&copier);
dbg!(&driver);
copier?;
driver?;
}
Expand Down
5 changes: 5 additions & 0 deletions src/imageproxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,11 @@ impl ImageProxy {
/// <https://github.com/opencontainers/image-spec/blob/main/descriptor.md>
///
/// The requested size and digest are verified (by the proxy process).
///
/// Note that because of the implementation details of this function, you should
Copy link
Contributor

@allisonkarlitskaya allisonkarlitskaya Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs here, btw.

/// [`futures::join!`] the returned futures instead of polling one after the other. The
/// secondary "driver" future will only return once everything has been read from
/// the reader future.
#[instrument]
pub async fn get_blob(
&self,
Expand Down
Loading