Skip to content

Ignore size value from GetBlob #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Ignore size value from GetBlob #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/imageproxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,9 +646,12 @@ impl ImageProxy {
tracing::debug!("fetching blob");
let args: Vec<serde_json::Value> =
vec![img.0.into(), digest.to_string().into(), size.into()];
let (bloblen, pipe): (u64, FinishPipe) =
// Note that size may be -1 here if e.g. the remote registry doesn't give a Content-Length
// for example.
// We have always validated the size later (in FinishPipe) so out of conservatism we
// just ignore the size here.
let (_bloblen, pipe): (serde_json::Number, FinishPipe) =
self.impl_request_with_fds("GetBlob", args).await?;
let _: u64 = bloblen;
let fd = tokio::fs::File::from_std(std::fs::File::from(pipe.datafd));
let fd = tokio::io::BufReader::new(fd);
let finish = Box::pin(self.finish_pipe(pipe.pipeid));
Expand Down