-
Notifications
You must be signed in to change notification settings - Fork 2
action: Add setup-rust composite action #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors CI workflows by creating a dedicated, reusable composite action for setting up the Rust development environment. This change improves the modularity and maintainability of CI configurations by isolating Rust-specific setup steps into their own action, making it easier to integrate Rust projects into various workflows without duplicating setup logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new composite action setup-rust to centralize the setup of the Rust toolchain, nextest, and caching. This is a good refactoring that improves reusability and separates concerns from the bootc-ubuntu-setup action. My review includes a suggestion to improve the robustness of the new action by pinning one of the used actions to a major version, which is a best practice for GitHub Actions to ensure workflow stability. The rest of the implementation looks solid.
This creates a reusable composite action for setting up Rust in CI workflows. It installs the Rust toolchain, nextest, and configures caching with Swatinem/rust-cache. This is moved out of the bootc-ubuntu-setup action because we shouldn't hardcode one thing specific to Rust there. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
9ae9cd6 to
47babcb
Compare
This creates a reusable composite action for setting up Rust in CI workflows. It installs the Rust toolchain, nextest, and configures caching with Swatinem/rust-cache.
This is moved out of the bootc-ubuntu-setup action because we shouldn't hardcode one thing specific to Rust there.
Assisted-by: Claude Code (Sonnet 4.5)