fix: stabilize tests by managing node lifecycle #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR stabilizes tests by properly managing the lifecycle of distributed system components, specifically ensuring clean shutdown of Raft consensus and transport layers. The changes address test flakiness by adding proper cleanup mechanisms and waiting for system readiness before tests proceed.
- Add Raft and transport manager references to Node struct for proper cleanup
- Implement proper shutdown sequence for Raft and transport components
- Replace fixed sleep with dynamic readiness checks for gRPC/Redis servers and Raft leader election
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| if n.tm != nil { | ||
| if err := n.tm.Close(); err != nil { | ||
| log.Printf("error closing transport: %v", err) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
undefined: log (typecheck)
| } | ||
| if n.tm != nil { | ||
| if err := n.tm.Close(); err != nil { | ||
| log.Printf("error closing transport: %v", err) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
undefined: log) (typecheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./...https://chatgpt.com/codex/tasks/task_e_6897642fe61c83249418501609499b8d