fix: stabilize tests by managing node lifecycle #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bootjp merged 1 commit into main from oj8pu0-codex/investigate-raft-node-connection-errors

Aug 9, 2025

Owner

bootjp commented Aug 9, 2025

Summary

ensure test nodes shut down raft and transport
add raft and transport to Node for cleanup
wait for gRPC/Redis servers and Raft leader before tests run
replace net.DialTimeout usage with DialContext and Dialer timeout
use ListenConfig to create gRPC and Redis listeners
remove redundant ctx redefinition in test helper
connect test clients to leader node to avoid stale reads
log transport close errors in test cleanup

Testing

go test ./... (fails: TestRedis_follower_redirect_node_set_get_deleted)
golangci-lint run

https://chatgpt.com/codex/tasks/task_e_6897642fe61c83249418501609499b8d


          test: log transport close errors

fcf753e

bootjp added the codex label

— with

ChatGPT Codex Connector

bootjp merged commit 6629c40 into main

6 of 7 checks passed

bootjp deleted the oj8pu0-codex/investigate-raft-node-connection-errors branch

August 9, 2025 17:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels