Skip to content

Fix nil pointer dereference panic in GRPC server methods during cluster initialization #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bootjp merged 4 commits into from
Aug 22, 2025
+4 −4
Merged

Fix nil pointer dereference panic in GRPC server methods during cluster initialization #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d37347
Initial plan
Copilot Aug 19, 2025
abcc835
Fix nil pointer dereference in GRPC server methods
Copilot Aug 19, 2025
883c75d
Simplify error handling: always use uint64(0) for CommitIndex on errors
Copilot Aug 20, 2025
3b98691
Merge branch 'main' into copilot/fix-dc945383-5925-4725-a58d-6e2e63e6…
bootjp Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions adapter/grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (r GRPCServer) RawPut(_ context.Context, req *pb.RawPutRequest) (*pb.RawPut
res, err := r.coordinator.Dispatch(m)
if err != nil {
return &pb.RawPutResponse{
CommitIndex: res.CommitIndex,
CommitIndex: uint64(0),
Success: false,
}, errors.WithStack(err)
}
Expand All @@ -88,7 +88,7 @@ func (r GRPCServer) RawDelete(ctx context.Context, req *pb.RawDeleteRequest) (*p
res, err := r.coordinator.Dispatch(m)
if err != nil {
return &pb.RawDeleteResponse{
CommitIndex: res.CommitIndex,
CommitIndex: uint64(0),
Success: false,
}, errors.WithStack(err)
}
Expand Down Expand Up @@ -122,7 +122,7 @@ func (r GRPCServer) Put(ctx context.Context, req *pb.PutRequest) (*pb.PutRespons
res, err := r.coordinator.Dispatch(reqs)
if err != nil {
return &pb.PutResponse{
CommitIndex: res.CommitIndex,
CommitIndex: uint64(0),
}, errors.WithStack(err)
}

Expand Down Expand Up @@ -163,7 +163,7 @@ func (r GRPCServer) Delete(ctx context.Context, req *pb.DeleteRequest) (*pb.Dele
res, err := r.coordinator.Dispatch(reqs)
if err != nil {
return &pb.DeleteResponse{
CommitIndex: res.CommitIndex,
CommitIndex: uint64(0),
}, errors.WithStack(err)
}

Expand Down
Binary file added elastickv
View file
Open in desktop
Binary file not shown.
Loading