Add range metrics and splitting engine with admin gRPC endpoints #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import "testing" | ||
|
|
||
| // Test range statistics collection and split triggering. | ||
| func TestRangeStatsAndSplit(t *testing.T) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
calculated cyclomatic complexity for function TestRangeStatsAndSplit is 12, max is 10 (cyclop)
| package distribution | ||
|
|
||
| import ( | ||
| "sync" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gci)
|
|
||
| // Test range statistics collection and split triggering. | ||
| func TestRangeStatsAndSplit(t *testing.T) { | ||
| var notified bool |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gci)
| // function is invoked whenever a range split occurs. | ||
| func NewEngine(threshold int, notify func(left, right Range)) *Engine { | ||
| return &Engine{ | ||
| ranges: []Range{{Start: "", End: string(rune(0xffff))}}, |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Magic number: 0xffff, in detected (mnd)
| s = start[0] | ||
| } | ||
| e := byte('z') | ||
| if len(end) > 0 && end != string(rune(0xffff)) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Magic number: 0xffff, in detected (mnd)
| if len(end) > 0 && end != string(rune(0xffff)) { | ||
| e = end[0] | ||
| } | ||
| m := s + (e-s)/2 |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Magic number: 2, in detected (mnd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./distribution -run Test -count=1https://chatgpt.com/codex/tasks/task_e_689871cad050832498b5c2fddf27a073