Remove Uint64ToInt64 function

[bootjp]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @bootjp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanup by removing the Uint64ToInt64 function from the internal/convert.go file. This function, which handled uint64 to int64 conversion with overflow checking, is no longer needed, simplifying the codebase and removing dead code.

Highlights

• Function Removal: The Uint64ToInt64 function has been completely removed from internal/convert.go.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the Uint64ToInt64 function. While this change appears to be a simple cleanup, it leaves a related function, Uint64ToInt, which contains a significant portability bug. The overflow check in Uint64ToInt is incorrect for 32-bit systems, potentially leading to silent integer overflows. I have added a detailed comment on this issue and strongly recommend fixing the bug in Uint64ToInt as part of this work to ensure the safety of type conversions across different architectures.

I am having trouble creating individual review comments. Click here to see my feedback.

internal/convert.go (11-16)

While removing this function seems reasonable if it's unused, the remaining Uint64ToInt function has a critical portability bug. Its overflow check if u > math.MaxInt64 is only valid on 64-bit systems. On 32-bit systems, where int is 32 bits, this check is insufficient and will allow values that cause a silent integer overflow when converted to int. This can lead to subtle and hard-to-debug issues. Before removing this correctly implemented function, it's important to fix Uint64ToInt to be platform-independent. A correct implementation would check against math.MaxInt (e.g., if u > uint64(math.MaxInt) for Go 1.17+).