Skip to content

Update Vagrantfile #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bootjp wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update Vagrantfile #293

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9abefce
Update Vagrantfile
bootjp Jan 3, 2026
009324f
Update Vagrantfile
bootjp Jan 3, 2026
88db435
Merge pull request #294 from bootjp/bootjp-patch-2
bootjp Jan 3, 2026
7816187
ci: configure jepsen workflow to use libvirt on ubuntu-latest
bootjp Jan 3, 2026
651320b
Update jepsen.yml
bootjp Jan 3, 2026
820031d
jepsen: use generic/debian12 box for libvirt provider
bootjp Jan 3, 2026
213c4ae
Merge branch 'bootjp-patch-1' of github.com:bootjp/elastickv into boo…
bootjp Jan 3, 2026
8946871
jepsen: allow libvirt driver fallback to qemu in CI
bootjp Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jepsen/Vagrantfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ Vagrant.configure("2") do |config|

# VirtualBox (Intel) defaults
node.vm.provider "virtualbox" do |vb|
vb.memory = name == :ctrl ? 4096 : 2048
vb.memory = name == :ctrl ? 2048 : 1024
vb.cpus = 2
end

# UTM (Apple Silicon) defaults
node.vm.provider "utm" do |utm|
utm.memory = name == :ctrl ? 4096 : 2048
utm.memory = name == :ctrl ? 2048 : 1024
Comment on lines +22 to +28
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Halving the memory allocation for both VirtualBox and UTM providers is a significant change that could impact the stability of the Jepsen test environment.

  • Control Node (2GB): The control node runs Jepsen (on a JVM) and compiles Go code. Both are memory-intensive operations, and 2GB might be insufficient, leading to Out-Of-Memory errors or slow performance.
  • Worker Nodes (1GB): The worker nodes run the elastickv service. 1GB of RAM might not be enough, depending on the service's memory footprint, especially under test load.

This change introduces a high risk of making the test environment unreliable.

For better maintainability and to avoid duplicating the memory values, consider defining them as variables at a higher scope. This would also make it easier for other developers to adjust them based on their system's resources.

Example:

# At the top of the Vagrantfile
CTRL_MEM = 2048
NODE_MEM = 1024

# ... then in the provider blocks
vb.memory = name == :ctrl ? CTRL_MEM : NODE_MEM
# and
utm.memory = name == :ctrl ? CTRL_MEM : NODE_MEM

Even better would be to allow overriding from environment variables:

CTRL_MEM = ENV.fetch('VAGRANT_CTRL_MEM', 2048)
NODE_MEM = ENV.fetch('VAGRANT_NODE_MEM', 1024)

utm.cpus = 2
end

Expand Down
Loading