Refactor serial command handling, add HTTP handlers, and expand parser tests#29
Open
Refactor serial command handling, add HTTP handlers, and expand parser tests#29
Conversation
| case "CO2": | ||
| parsed, err := strconv.ParseFloat(value, 64) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error returned from external package is unwrapped: sig: func strconv.ParseFloat(s string, bitSize int) (float64, error) (wrapcheck)
| case "HUM": | ||
| parsed, err := strconv.ParseFloat(value, 64) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error returned from external package is unwrapped: sig: func strconv.ParseFloat(s string, bitSize int) (float64, error) (wrapcheck)
| case "TMP": | ||
| parsed, err := strconv.ParseFloat(value, 64) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error returned from external package is unwrapped: sig: func strconv.ParseFloat(s string, bitSize int) (float64, error) (wrapcheck)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runto improve readability and make the HTTP endpoints easier to adjust.parserto validate edge cases and input robustness.Description
startCommand,stopCommand, andcommandHeaderLinesand use them where commands/header skipping are needed inmain.go.parseKeyValue,openSerialPort, andwriteCommandhelper functions and updaterecordMetricsto use these helpers and a loop-driven header-skip instead of inline logic.metricsHandlerandindexHandlerfunctions and register them inruninstead of inlining the handler code.main_test.gowith named subtests and additional cases (invalid values, unknown keys ignored, missing equals ignored) to exerciseparserbehavior.Testing
go test ./...and all tests passed.main_test.go) and executed them as part of the test run which succeeded.Codex Task