Register nvws as builder for work profiles by booxter · Pull Request #172 · booxter/nix

booxter · 2026-02-23T18:17:40Z

No description provided.

Copilot

Pull request overview

Registers nvws as a remote builder for “work” hosts by splitting builder configuration into personal vs. work builder mixins and wiring them into the common module import graph.

Changes:

Add common/_mixins/work-builders to configure SSH host metadata and register nvws in nix.buildMachines for work profiles.
Add common/_mixins/personal-builders to configure SSH host metadata and register personal builders/hosts in nix.buildMachines for non-work profiles that can use builders.
Update common/default.nix import selection logic and update README machine description for nvws.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
common/default.nix	Adds `canUseWorkBuilders` gating and switches builder imports to `personal-builders` (personal) and `work-builders` (work).
common/_mixins/work-builders/default.nix	New mixin: adds SSH config for `nvws` and registers it as an `ssh-ng` build machine for work hosts.
common/_mixins/personal-builders/default.nix	New mixin: adds SSH config for personal hosts/builders and registers multiple `ssh-ng` build machines for non-work hosts.
README.md	Documents `nvws` as also serving as a remote builder for work machines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

In work env, all dns queries are funneled through corp dns server.

Some policy seems to block nixpkgs ssh binary from accessing local resources via .local sigh.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T21:39:29Z

common/default.nix

@@ -29,7 +30,10 @@ in
  ]
  ++ lib.optionals canUseBuilders [
    ./_mixins/community-builders
-    ./_mixins/remote-builders
+    ./_mixins/personal-builders
+  ]
+  ++ lib.optionals canUseWorkBuilders [
+    ./_mixins/work-builders
  ];


canUseWorkBuilders already excludes hostname == "nvws", and _mixins/work-builders also guards nix.buildMachines with (hostname != "nvws"). This duplicates the same policy in two places and risks divergence later. Prefer to keep the exclusion in only one place (either gate the import or gate the nix.buildMachines entry).

Copilot · 2026-02-23T21:39:30Z

common/_mixins/work-builders/default.nix

+  nix.buildMachines = lib.optional (hostname != "nvws") {
+    hostName = "nvws.local";
+    system = "x86_64-linux";
+    protocol = "ssh-ng";
+    maxJobs = 4;
+    speedFactor = 100;
+    supportedFeatures = [
+      "nixos-test"
+      "benchmark"
+      "big-parallel"
+      "kvm"
+    ];
+  };


nix.buildMachines is wrapped in lib.optional (hostname != "nvws"), but this module is already only imported when hostname != "nvws" (via canUseWorkBuilders in common/default.nix). Consider removing this extra guard to avoid having the same condition in two places.

Suggested change

nix.buildMachines = lib.optional (hostname != "nvws") {

hostName = "nvws.local";

system = "x86_64-linux";

protocol = "ssh-ng";

maxJobs = 4;

speedFactor = 100;

supportedFeatures = [

"nixos-test"

"benchmark"

"big-parallel"

"kvm"

];

};

nix.buildMachines = [

{

hostName = "nvws.local";

system = "x86_64-linux";

protocol = "ssh-ng";

maxJobs = 4;

speedFactor = 100;

supportedFeatures = [

"nixos-test"

"benchmark"

"big-parallel"

"kvm"

];

}

];

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T22:19:22Z

README.md

 | `pi5` | NixOS (Raspberry Pi) | DHCP and network services for the lab. | [nixos/pi5/default.nix](nixos/pi5/default.nix) | [common](common), [nixos](nixos) |
 | `beast` | NixOS (x86_64-linux) | NAS storage + Jellyfin/Jellarr server. | [nixos/beast/default.nix](nixos/beast/default.nix) | [common](common), [nixos](nixos) |
-| `nvws` | Proxmox host | Work Proxmox node configuration. Single node. | [nixos/nvws/default.nix](nixos/nvws/default.nix) | [common](common), [nixos](nixos) |
+| `nvws` | Proxmox host | Work Proxmox node configuration. Single node. Also serves as a remote x86_64-linux builder for work machines. | [nixos/nvws/default.nix](nixos/nvws/default.nix) | [common](common), [nixos](nixos) |


The README description states nvws serves as "a remote x86_64-linux builder", but the work-builders configuration in common/_mixins/work-builders/default.nix shows it supports both "x86_64-linux" and "aarch64-linux" systems. The description should be updated to accurately reflect that it supports both architectures, for example: "Also serves as a remote x86_64-linux and aarch64-linux builder for work machines."

Suggested change

| `nvws` | Proxmox host | Work Proxmox node configuration. Single node. Also serves as a remote x86_64-linux builder for work machines. | [nixos/nvws/default.nix](nixos/nvws/default.nix) | [common](common), [nixos](nixos) |

| `nvws` | Proxmox host | Work Proxmox node configuration. Single node. Also serves as a remote x86_64-linux and aarch64-linux builder for work machines. | [nixos/nvws/default.nix](nixos/nvws/default.nix) | [common](common), [nixos](nixos) |

Emulation won't serve my needs - being able to build aarch64 images. Some syscalls are not properly emulated. :( This reverts commit 7a31e79.

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T02:44:48Z

common/_mixins/work-builders/default.nix

+{
+  lib,
+  config,
+  username,
+  hostname,
+  ...
+}:


The work-builders module is missing the pkgs import in the function arguments and does not include openssh_gssapi in environment.systemPackages. The personal-builders module includes both (lines 4 and 56), and the community-builders module also includes openssh_gssapi. This package is likely needed for SSH connections to work properly with the builder. Consider adding pkgs to the function arguments and including environment.systemPackages = [ pkgs.openssh_gssapi ] to match the pattern in other builder configurations.

Register nvws as builder for work profiles

7c9e88a

Copilot AI review requested due to automatic review settings February 23, 2026 18:17

Copilot started reviewing on behalf of booxter February 23, 2026 18:18 View session

booxter enabled auto-merge February 23, 2026 18:20

Copilot AI reviewed Feb 23, 2026

View reviewed changes

booxter added 2 commits February 23, 2026 15:58

Use .local address for nvws builder

a83906e

In work env, all dns queries are funneled through corp dns server.

Don't inject nixpkgs ssh into system env on work profiles

fa50d40

Some policy seems to block nixpkgs ssh binary from accessing local resources via .local sigh.

Copilot AI review requested due to automatic review settings February 23, 2026 21:33

Copilot started reviewing on behalf of booxter February 23, 2026 21:34 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

booxter added 2 commits February 23, 2026 17:07

Enable aarch64 emulation on nvws builder

7a31e79

update: use mDNS when updating work machines

fda9160

Copilot AI review requested due to automatic review settings February 23, 2026 22:14

Copilot started reviewing on behalf of booxter February 23, 2026 22:15 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

booxter and others added 2 commits February 23, 2026 17:59

Revert "Enable aarch64 emulation on nvws builder"

de05e38

Emulation won't serve my needs - being able to build aarch64 images. Some syscalls are not properly emulated. :( This reverts commit 7a31e79.

Merge branch 'master' into nvws-as-builder

e591200

Copilot AI review requested due to automatic review settings February 24, 2026 02:40

Copilot started reviewing on behalf of booxter February 24, 2026 02:42 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

booxter merged commit 18cfd54 into master Feb 24, 2026
27 checks passed

booxter deleted the nvws-as-builder branch February 24, 2026 03:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Register nvws as builder for work profiles#172

Register nvws as builder for work profiles#172
booxter merged 7 commits intomasterfrom
nvws-as-builder

booxter commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	\| `nvws` \| Proxmox host \| Work Proxmox node configuration. Single node. Also serves as a remote x86_64-linux builder for work machines. \| [nixos/nvws/default.nix](nixos/nvws/default.nix) \| [common](common), [nixos](nixos) \|
	\| `nvws` \| Proxmox host \| Work Proxmox node configuration. Single node. Also serves as a remote x86_64-linux and aarch64-linux builder for work machines. \| [nixos/nvws/default.nix](nixos/nvws/default.nix) \| [common](common), [nixos](nixos) \|

Comments

Conversation

booxter commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant