Skip to content

Comments

Move ci readme to avoid it shown by default on github#180

Merged
booxter merged 1 commit intomasterfrom
readme-mess
Feb 24, 2026
Merged

Move ci readme to avoid it shown by default on github#180
booxter merged 1 commit intomasterfrom
readme-mess

Conversation

@booxter
Copy link
Owner

@booxter booxter commented Feb 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 24, 2026 16:46
@booxter booxter enabled auto-merge February 24, 2026 16:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 7 to 15
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "High-level flow" list implies plan-build-matrix runs before format, but in .github/workflows/build-targets.yml those jobs have no dependency and will run in parallel. Also get-hosts-check/flake-check depend on plan-build-matrix (not format), and build depends on both format and the heavy checks. Please update this section to reflect the actual job dependency graph so readers don't assume a strict sequential order.

Suggested change
For pull requests, CI jobs are wired as:
- `plan-build-matrix` and `format` start immediately and run in parallel.
- Heavy jobs run only when the PR is not docs-only:
- `get-hosts-check` (depends on `plan-build-matrix`)
- `flake-check` (depends on `plan-build-matrix`)
- `build` matrix (scoped dynamically; depends on `format`, `get-hosts-check`, and `flake-check`)
- `ci-success` runs last and depends on completion of all required jobs above.

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 4
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository README.md currently points CI documentation to .github/README.md, but this PR adds .github/README-internal.md instead, leaving the existing link broken. Either rename this file to .github/README.md (if acceptable) or update the root README link in the same PR so CI docs remain discoverable.

Copilot uses AI. Check for mistakes.
@booxter booxter merged commit 28b66cf into master Feb 24, 2026
10 checks passed
@booxter booxter deleted the readme-mess branch February 24, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant