Skip to content

Pin transmission to particular nixpkgs hash #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
booxter merged 1 commit into from
Mar 4, 2026
Merged

Pin transmission to particular nixpkgs hash #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
nixpkgs-25_11.url = "github:NixOS/nixpkgs/release-25.11";
# Keep Transmission pinned independently from the moving release-25.11 branch.
# TODO: remove this input when trackers allow 4.1.0+.
nixpkgs-transmission.url = "github:NixOS/nixpkgs/12d60a4f2d5f2cc96e93ae5615328245d49ac2e8";

# Use staging-next if needed
#nixpkgs-staging-next.url = "github:NixOS/nixpkgs/staging-next";
Expand Down
13 changes: 5 additions & 8 deletions overlays/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,10 @@
pkgs = getPkgs inputs.nixpkgs;
pkgsLldb = getPkgs inputs.debugserver;
pkgsRelease = getPkgs inputs.nixpkgs-25_11;
pkgsTransmission = getPkgs inputs.nixpkgs-transmission;
pkgsQuartzWm = getPkgs inputs.nixpkgs-quartz-wm;
llmAgentsPkgs = inputs.llm-agents.packages.${prev.system};
releaseTransmission =
if prev.lib.strings.hasPrefix "4.0." pkgsRelease.transmission_4.version then
pkgsRelease.transmission_4
else
throw "Expected transmission_4 from nixpkgs-25_11 to be 4.0.x, got ${pkgsRelease.transmission_4.version}";
pinnedTransmission = pkgsTransmission.transmission_4;
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the previous guard that validated Transmission stays on 4.0.x (and provided a clear error if it drifted). Even though the input is pinned by commit, it’s still easy to update that hash later and accidentally jump to 4.1+. Consider reintroducing an explicit version assertion/throw around pinnedTransmission (similar to the prior releaseTransmission check) so future bumps fail fast with a clear message.

Suggested change
pinnedTransmission = pkgsTransmission.transmission_4;
pinnedTransmission =
let
transmission = pkgsTransmission.transmission_4;
version = transmission.version or "";
in
if inputs.nixpkgs.lib.hasPrefix "4.0." version then
transmission
else
throw ''
Transmission input drifted: expected 4.0.x but got ${version}.
Please update overlays/default.nix and the nixpkgs-transmission input together.
'';

Copilot uses AI. Check for mistakes.
# Temporary Darwin firefox wrapper backport:
# in our pinned nixpkgs revision, wrapper logic copies only *.dylib symlinks.
# Some shared libraries are Mach-O dylibs without that suffix, which leaves them
Expand Down Expand Up @@ -61,11 +58,11 @@
# pull latest from nixpkgs; ignore what comes from rpi5 repo nixpkgs
inherit (pkgs) netbootxyz-efi;

# Pull Sonarr/Readarr and pin Transmission to 4.0.x from release-25.11.
# Pull Sonarr/Readarr from release-25.11 and pin Transmission via a dedicated nixpkgs input.
# TODO: report issues; investigate; fix
inherit (pkgsRelease) readarr sonarr;
transmission_4 = releaseTransmission;
transmission = releaseTransmission;
transmission_4 = pinnedTransmission;
transmission = pinnedTransmission;
Comment on lines +64 to +65
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the previous guard that validated Transmission stays on 4.0.x (and provided a clear error if it drifted). Even though the input is pinned by commit, it’s still easy to update that hash later and accidentally jump to 4.1+. Consider reintroducing an explicit version assertion/throw around pinnedTransmission (similar to the prior releaseTransmission check) so future bumps fail fast with a clear message.

Copilot uses AI. Check for mistakes.

jellyfin = prev.jellyfin.overrideAttrs (old: {
patches = old.patches or [ ] ++ [
Expand Down
Loading