-
-
Notifications
You must be signed in to change notification settings - Fork 811
Small change to warn about symlinks pointing outside of a backup #9255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.4-maint
Are you sure you want to change the base?
Conversation
…using borg mount adds warning about symlinks pointing out if the fuse filesystem when using borg mount
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Good idea to have this as an easy/quick fix until we might have something better.
|
I think i am happy with the wordings now |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9255 +/- ##
=============================================
- Coverage 80.59% 80.57% -0.02%
=============================================
Files 38 38
Lines 11256 11256
Branches 1771 1771
=============================================
- Hits 9072 9070 -2
- Misses 1615 1616 +1
- Partials 569 570 +1 ☔ View full report in Codecov by Sentry. |
Hi, this is related to #9254, and should implement the most basic version of "the easy option" outlined there.
It implements a warning about symlinks pointing outside of the backup mountpoint when using borg mount and adds it to the
borg mountdocumentation as well as logs such a warning on a mount call.I will mark this as a draft as i see this more as a preliminary suggestion.