This repository was archived by the owner on Apr 2, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Hybrid parser #34
Open
bosd
wants to merge
129
commits into
bosd:hybrid-sqaushed
Choose a base branch
from
FrancoisHuet:hybrid-parser
base: hybrid-sqaushed
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hybrid parser #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop EOL Python 2 support. Resolve unit test discrepancies. Update unit tests to pass in Travis across all supported Py. Linting.
Move common code to base class to reduce duplication Stream plots display pdf background for better context
Refactor parsers by moving common code to the base class
Maintain Python 3.5 compatibility by removing f"{}"
Move common parse error stats computation to base parser Move copy_spanning_text logic to the table
* plot info passed through debug_info * display each text edge
* Display regions and areas rectangles
Accept cells if they're at least 50% within the table's bounds.
Plot takes an optional axes parameter, allowing notebooks more flexibility. Header heuristic in hybrid won't include headers which span the entire table. Added unit test for issue camelot-dev#132 Fixes camelot-dev#132
f-strings fail unit tests in Python <3.7, removed them for .format. Made download_url simulate Mozilla/5.0 to restore unit tests, since server targetted was 403ing.
plot.text shows vertical text in red _generate_columns_and_rows split between hybrid and stream
Plot vertical col anchors found by hybrid parser Include vertical text in col/row generation
While searching for table body boundaries, exclude rows that include cells crossing previously discovered rows.
No longer rely on the mode but on the parsing analysis during network detection. Added unit test for complex table with vertical header and mixed horizontal / vertical text.
Enforce order of textline plotting for unit test consistency in 3.6. Create wrapper around camelot plot that enforces backwards consistency with older versions of matplotlib.
Create hybrid parser leverage both lattice and network techniques. Simplify plotting of pdf in lattice case. Rename "parser.table_bbox" into "parser.table_bbox_parses", since it represents not a bbox but a dict of bbox to corresponding parsing data. Still missing: more unit tests, plotting of steps.
Fix first split merge issue
Improve parser comparison notebook to flag identical parses, display multiple tables correctly Fix tolerance parameter inclusion for hybrid.
Trim empty cols and lines
… into hybrid-parser
* If Travis uses pytest-cov >= 2.10, it also needs pytest >= 4.6
* Clean up the parser comparison notebook * Address issue where hybrid didn't honor the columns parameter * Fix dropping of empty rows/columns in hybrid * Hybrid learns table y-dimensions from lattice
* Improve explanations of network, hybrid, and lattice parsers * Remove dead code from parser comparison notebook * Clean-up notebook variables to reduce size and make diffs cleaner * Revert changes that were peripheral to the core changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.