Skip to content

Conversation

@levalleux-ludo
Copy link
Member

Description

{{what was done}}

How to test

{{how can it be tested}}

@levalleux-ludo levalleux-ludo marked this pull request as ready for review March 23, 2023 17:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #467 (5456277) into main (13c4b7c) will decrease coverage by 1.13%.
The diff coverage is n/a.

❗ Current head 5456277 differs from pull request most recent head f56c87c. Consider uploading reports for the commit f56c87c to get more accurate results

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   55.78%   54.65%   -1.13%     
==========================================
  Files         121      127       +6     
  Lines        3460     3692     +232     
  Branches      575      629      +54     
==========================================
+ Hits         1930     2018      +88     
- Misses       1530     1674     +144     
Flag Coverage Δ
common 84.82% <ø> (+0.21%) ⬆️
core-sdk 51.22% <ø> (-1.34%) ⬇️
eth-connect-sdk 18.30% <ø> (ø)
ethers-sdk 67.12% <ø> (+0.99%) ⬆️
ipfs-storage 94.02% <ø> (ø)
metadata 97.56% <ø> (ø)
unittests 54.65% <ø> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* fix: USDC approve fails from DCL

* change package version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants