Skip to content

Conversation

@levalleux-ludo
Copy link
Member

@levalleux-ludo levalleux-ludo commented Sep 11, 2025

fixed #967
fixes #954

Description

DONE:

  • changed event BuyerCommitted: added field "mutualizerAddress" for "exchange" parameter
  • changed event OfferCreated: new fields "creator" and "buyerId" in offer struct + field "mutualizerAddress" in disputeResolutionTerms
  • change method signature resolveDispute() (related to protocol upgrade - impact on resolveDispute() #954)
  • changed event OfferVoided: sellerId renamed creatorId
  • method "commitToOffer()" moved to ExchangeCommit ABI
  • method "commitToConditionalOffer()"moved to ExchangeCommit ABI
  • method "isEligibleToCommit()" moved to ExchangeCommit ABI (NO IMPACT)
  • method "onPremintedVoucherTransferred" moved to ExchangeCommit ABI (NO IMPACT)
  • changed method "getExchange()": added field "mutualizerAddress" for "exchange" argument (NO IMPACT)
  • method depositFunds(): argument _sellerId is renamed into _entityId
  • changed method "getOffer": new fields "creator" and "buyerId" in offer struct + field "mutualizerAddress" in disputeResolutionTerms (NO IMPACT)
  • createGroup() now requires to explicitely specify the sellerId
  • changed methods: new fields "creator" and "buyerId" in offer struct +_disputeResolverId replaced with _drParameters struct
    • createOffer()
    • createOfferBatch()
    • createOfferAddToGroup()
    • createOfferAndTwinWithBundle()
    • createOfferWithCondition()
    • createOfferWithConditionAndTwinAndBundle
    • createPremintedOfferAddToGroup
    • createPremintedOfferAndTwinWithBundle
    • createPremintedOfferWithCondition
    • createPremintedOfferWithConditionAndTwinAndBundle
    • createSellerAndOffer
    • createSellerAndOfferAndTwinWithBundle
    • createSellerAndOfferWithCondition
    • createSellerAndOfferWithConditionAndTwinAndBundle
    • createSellerAndPremintedOffer
    • createSellerAndPremintedOfferAndTwinWithBundle
    • createSellerAndPremintedOfferWithCondition
    • createSellerAndPremintedOfferWithConditionAndTwinAndBundle
  • changed method executeMetaTransaction() modified (sigR/sigS/sigV replaced with signature: bytes)

COMPATIBILTY BREAKS:

  • createGroup() now requires to explicitely specify the sellerId

DEPENDENCIES:

OTHER CHANGES (WILL BE HANDLED IN SEPARATE PRs)

  • createOfferAndCommit (implement createOfferAndCommit() feature #966)

    • new method createOfferAndCommit()
    • new event NonListedOfferVoided
    • new method "getOfferHash()"
    • new method voidNonListedOffer()
    • new method voidNonListedOfferBatch()
  • buyer-initiated offers (implement buyer initiated offer feature #965)

    • new event BuyerInitiatedOfferSetSellerParams
    • new event SellerCommitted
    • new method "commitToBuyerOffer()"
  • DR fee mutualizer (implement DR fees mutualizer feature #964)

    • new event DRFeeRequested
    • new event DRFeeReturned
    • new event OfferMutualizerUpdated
    • new method updateOfferMutualizer()
    • new client contract DRFeeMutualizer (related to with:
      • method isSellerCovered()
      • method requestDRFee()
      • method returnDRFee()
      • event FundsDeposited
      • event FundsWithdrawn
      • event DRFeeProvided
      • event DRFeeReturned
      • event AgreementCreated
      • event AgreementActivated
      • event AgreementVoided

How to test

  • current test suites to ensure non regression
  • a few tests added to avoid negative impact on coverage

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (a80c69e) to head (57444ea).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   89.75%   90.51%   +0.76%     
==========================================
  Files         164      176      +12     
  Lines        6704     6867     +163     
  Branches     1229     1241      +12     
==========================================
+ Hits         6017     6216     +199     
+ Misses        687      651      -36     
Flag Coverage Δ
common 91.60% <100.00%> (+0.47%) ⬆️
core-sdk 57.13% <69.04%> (+2.08%) ⬆️
e2e 85.74% <96.42%> (-0.18%) ⬇️
eth-connect-sdk 95.06% <ø> (ø)
ethers-sdk 74.45% <ø> (-0.72%) ⬇️
ipfs-storage 91.75% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 61.36% <76.78%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@levalleux-ludo levalleux-ludo marked this pull request as ready for review September 16, 2025 11:20
Copy link
Collaborator

@albertfolch-redeemeum albertfolch-redeemeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@levalleux-ludo levalleux-ludo merged commit 8669cf3 into main Sep 17, 2025
11 of 13 checks passed
@levalleux-ludo levalleux-ludo deleted the upgrade-contracts-2.5.0 branch September 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to contract 2.5.0 protocol upgrade - impact on resolveDispute()

3 participants