Improving Win Apps module to support pywinauto's Desktop class #55
Conversation
| if "path" in connection_selectors.keys(): | ||
| connection_selectors.pop("path") | ||
|
|
||
| def find_window(app: Application, waiting_time=10000, **selectors) -> WindowSpecification: | ||
| if not connection_selectors: | ||
| if connect_exception: | ||
| raise connect_exception | ||
| return None | ||
|
|
||
| app = Desktop(backend=backend).window(**connection_selectors) | ||
| if not app.exists(): | ||
| raise WindowNotFoundError(f"Unable to find an app using these criteria: {connection_selectors}") | ||
| return app |
There was a problem hiding this comment.
This implementation idea looks great, but I think we can possibly improve it.
As of now, it will try up to timeout milliseconds to connect to the Application and only if that fails it will try the fallback method with the Desktop approach.
While the Desktop approach was introduced to handle a corner case, I believe it could be added into the timeout loop in some way for us to also check using this method if the Application connection fails as an alternative to speed up and not required that applications relying on the Desktop.window method wait the full timeout period before they can connect.
What do you think?
|
Here are some updates about the 'Application' and 'Desktop' classes...
|
No description provided.