MNT: add type annotations and improve code style in display methods #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added type annotations to several methods in the DesktopBot class to enhance code readability and enable static type checking: - _fix_display_size: Returns a Tuple[int, int]. - display_size: Returns a Tuple[int, int]. - screenshot: Accepts Optional[str] for filepath and Optional[Tuple[int, int, int, int]] for region, and returns Image.Image. - get_screenshot: Same parameters and return type as screenshot. - screen_cut: Parameters now include x: int = 0, y: int = 0, and Optional[int] for width and height. Returns Image.Image. - save_screenshot: Parameter path is typed as str, and the method returns None. Improving formatting consistency: - added spacing around arithmetic operators in _fix_display_size. - Replaced redundant default value assignments (x = x or 0) with cleaner initial parameter values. Also updated imports to include Tuple and Optional from typing.
joao-voltarelli
approved these changes
Dec 13, 2024
|
@welli7ngton great work! Thanks for the contribution. |
|
@joao-voltarelli i will soon be working on the next functions following the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to some methods in the DesktopBot class to enhance code readability and enable static type checking:
Improving formatting consistency:
Also updated imports to include Tuple and Optional from typing.
This PR is related to issue