Skip to content

Conversation

@welli7ngton
Copy link
Contributor

MNT

  • add to imports: NamedTuple, Iterable and List

  • add annotation to: add_image, get_image_from_map, find_multiple, find find_until, find_all, find_text, find_process, get_last_element, screenshot get_screenshot, screen_cut, get_element_coords, get_element_coords_centered

  • updated the documentation from methods: find_multiple, find, find_until find_all, find_text, find_process, get_element_coords

  • removed the duplicity of (x,y) variables by setting a default value in the function definition

     old:
        x = x or 0
        y = y or y
     new (in function definition):
        x: int = 0
        y: int = 0

Automatic linter changes:

I'm currently using pyright, black and flake8 to help with linting, formatting and code style.

changes related to the next functions were made by the linters.

  • added double quotes as default logging
  • updated the identation of some functions uses: functools.partial(), _replace() locate_all_opencv(), locate_all_opencv(), find_all(), click(), click_relative() mouse_click(), double_click_relative(), find_app_window(), find_app_element() connect_to_app(), right_click_relative()

The second PR related to the issue #49

- add to imports: NamedTuple, Iterable and List

- add annotation to: add_image, get_image_from_map, find_multiple, find
find_until, find_all, find_text, find_process, get_last_element, screenshot
get_screenshot, screen_cut, get_element_coords, get_element_coords_centered

- updated the documentation from methods: find_multiple, find, find_until
find_all, find_text, find_process, get_element_coords

- removed the duplicity of (x,y) variables by setting a default value in the
function definition

Automatic linter changes:

I'm currently using pyright, black and flake8 to help with linting, formatting
and code style

- added double quotes as default logging
- updated the identation of some functions uses: functools.partial(), _replace()
locate_all_opencv(), locate_all_opencv(), find_all(), click(), click_relative()
mouse_click(), double_click_relative(), find_app_window(), find_app_element()
connect_to_app(), right_click_relative()
@welli7ngton
Copy link
Contributor Author

studying a better way to annotate this function, nice tests guys! ;)

@welli7ngton welli7ngton deleted the mnt/add_type_annotation_computer_vision_functions branch December 15, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant