Task/remove match class #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR removes the Match class and refactors the code to use primitive int values for tracking priority instead. The changes also update target framework versions to .NET 10.0.
Key changes:
- Replaced the
Matchclass with simpleintvariables for priority tracking - Moved
NoMatchPriorityconstant to the class level - Updated target frameworks from .NET 9.0 to .NET 10.0
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RobotsTxt/RobotsMachine.cs | Removed Match class, refactored to use int for priority tracking, added class-level constant |
| TestRobotsTxt/TestRobotsMachine.cs | Updated code style to use collection expressions and reformatted test attributes |
| TestRobotsTxt/TestRobotsTxt.csproj | Updated target framework from net9.0 to net10.0 |
| ConsoleApplication/ConsoleApplication.csproj | Changed from multi-targeting to single target framework net10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.