Include stacktrace of exception cause in stacktrace#446
Merged
Conversation
8472d43 to
c4cd018
Compare
c4cd018 to
35ec5e6
Compare
Contributor
Author
|
@ybastide I don't understand your last commit ? |
Contributor
Author
|
HAHA it depends on the python version. They don't all print tracebacks the same way :D |
d15fb6b to
b9638e7
Compare
b9638e7 to
1d20530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can see, if we use
traceback.format_exception, we end up having the full exception, including its causes, whereas with format_tb we only have the last exception which can be far less informative.This PR makes the exception tracebacks more informative.