(Suggestion) Removing the default higher role for rolecommand panel#1801
Merged
ashishjh-bst merged 1 commit intobotlabs-gg:devfrom Dec 24, 2024
Merged
Conversation
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(mb for the branch)
Following this suggestion (✅
9vs ❎2)Just added in webTemplate
Suggestion:
In Role Commands, the "default" role / the role set before changing anything is set to the highest ranked manageable role. I think it would be better to either be set to "None," in which case you would not be able to save without setting one, or the lowest ranked manageable role to prevent accidents in cases where something like this (link expired) happens.