-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add official warnings for the removal of six from vendoring #3504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3504 +/- ##
===========================================
+ Coverage 92.94% 93.13% +0.19%
===========================================
Files 66 67 +1
Lines 14956 15270 +314
===========================================
+ Hits 13901 14222 +321
+ Misses 1055 1048 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for doing this @nateprewitt I was planning to propose a more intrusive patch on Debian side something of the likes of
https://wiki.debian.org/Python3-six-removal Greetings |
With the release of Botocore 1.11.0 in 2018, the
botocore.vendoredmodule was deprecated and a majority of the contents were removed. The remaining pieces for Requests have been left along with a copy ofsix. Thesixmodule was deprecated in 2021 when Python 2 support was dropped but left for backwards compatibility.Now that botocore hasn't supported Python 2.7 for 4 years, we intend to remove this from the library in a future release. In the interim, warnings will be raised when direct imports are made against either the
compatorvendorinstances ofsix.This includes both of the below syntaxes:
Customers who still need
sixshould add it to their direct dependencies to receive the latest updates.