Skip to content

Make FileUpload.save accept Path instance for destination #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johndoe46 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

Make FileUpload.save accept Path instance for destination #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bottle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def _cli_patch(cli_args): # pragma: no coverage
from tempfile import NamedTemporaryFile
from traceback import format_exc, print_exc
from unicodedata import normalize
from pathlib import Path

try:
from ujson import dumps as json_dumps, loads as json_lds
Expand Down Expand Up @@ -2673,6 +2674,8 @@ def save(self, destination, overwrite=False, chunk_size=2 ** 16):
:param overwrite: If True, replace existing files. (default: False)
:param chunk_size: Bytes to read at a time. (default: 64kb)
"""
if isinstance(destination, Path):
destination = str(destination)
if isinstance(destination, str): # Except file-likes here
if os.path.isdir(destination):
destination = os.path.join(destination, self.filename)
Expand Down