Add dependency on the GRID license for kubelet #294
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| NVidiaEULAforAWS.pdf | ||
| COPYING | ||
| *.rpm | ||
| NvidiaGridAWSUserLicenseAgreement.DOCX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [Unit] | ||
| Description=GRID License Check | ||
| RefuseManualStart=true | ||
| RefuseManualStop=true | ||
| DefaultDependencies=no | ||
| Before=kubelet.service | ||
| After=nvidia-gridd.service | ||
| Requires=nvidia-gridd.service | ||
|
|
||
| [Service] | ||
| Type=oneshot | ||
| ExecCondition=/usr/bin/ghostdog match-nvidia-driver grid | ||
| # Otherwise, attempt to load the module. | ||
| ExecStart=/usr/bin/nvidia-smi -q | ||
| # Ensure that the stderr file exists. Otherwise, grep fails on an empty file. | ||
| ExecStart=-/usr/bin/touch /tmp/.nvidia-gridd-license | ||
|
Comment on lines
+15
to
+16
Contributor
There was a problem hiding this comment.
(would have to move this before the
Contributor
Author
There was a problem hiding this comment. I like that, I'll give it a shot to see if it still gives me the behavior I want with things rearranged to use |
||
| # Succeed unless there was a fatal error. | ||
| ExecStart=/usr/bin/grep -Fqvzw Unlicensed /tmp/.nvidia-gridd-license | ||
| RemainAfterExit=true | ||
| StandardOutput=append:/tmp/.nvidia-gridd-license | ||
| Restart=on-failure | ||
| RestartSec=1 | ||
| StartLimitBurst=120 | ||
|
|
||
| [Install] | ||
| RequiredBy=kubelet.service | ||
|
Comment on lines
+25
to
+26
Contributor
There was a problem hiding this comment. Below it's required by
Contributor
Author
There was a problem hiding this comment. Sorry, this was originally
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| NVidiaEULAforAWS.pdf | ||
| COPYING | ||
| *.rpm | ||
| NvidiaGridAWSUserLicenseAgreement.DOCX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [Unit] | ||
| Description=GRID License Check | ||
| RefuseManualStart=true | ||
| RefuseManualStop=true | ||
| DefaultDependencies=no | ||
| Before=kubelet.service | ||
| After=nvidia-gridd.service | ||
| Requires=nvidia-gridd.service | ||
|
|
||
| [Service] | ||
| Type=oneshot | ||
| ExecCondition=/usr/bin/ghostdog match-nvidia-driver grid | ||
| # Otherwise, attempt to load the module. | ||
| ExecStart=/usr/bin/nvidia-smi -q | ||
| # Ensure that the stderr file exists. Otherwise, grep fails on an empty file. | ||
|
Contributor
There was a problem hiding this comment. It's the STDOUT file what you are creating, right?
Contributor
Author
There was a problem hiding this comment. Yes, this is a forgotten update, I moved to STDOUT but forgot to update the comment. |
||
| ExecStart=-/usr/bin/touch /tmp/.nvidia-gridd-license | ||
| # Succeed unless there was a fatal error. | ||
| ExecStart=/usr/bin/grep -Fqvzw Unlicensed /tmp/.nvidia-gridd-license | ||
| RemainAfterExit=true | ||
| StandardOutput=append:/tmp/.nvidia-gridd-license | ||
| Restart=on-failure | ||
| RestartSec=1 | ||
| StartLimitBurst=120 | ||
|
|
||
| [Install] | ||
| RequiredBy=nvidia-k8s-device-plugin.service | ||
|
Comment on lines
+25
to
+26
Contributor
There was a problem hiding this comment. Does this requirement cause the k8s device plugin to fail if the license check fails? I'm kind of worried about cluttering up the logs with a lot of failures. This could possibly be modeled as:
Contributor
Author
There was a problem hiding this comment. This might be much cleaner in the logs, otherwise the unit is very angry and noisy in the journal when its failing. I'll play with that as a potential alternative to this. FWIW though I haven't seen this fail yet before the next unit runs when we are going to get a license, so it might be a situation where the only time its noisy, is when the node is already in a bad state. Nonetheless, I think making it cleaner is worth it. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| NVidiaEULAforAWS.pdf | ||
| COPYING | ||
| *.rpm | ||
| NvidiaGridAWSUserLicenseAgreement.DOCX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [Unit] | ||
| Description=GRID License Check | ||
| RefuseManualStart=true | ||
| RefuseManualStop=true | ||
| DefaultDependencies=no | ||
| Before=kubelet.service | ||
| After=nvidia-gridd.service | ||
| Requires=nvidia-gridd.service | ||
|
|
||
| [Service] | ||
| Type=oneshot | ||
| ExecCondition=/usr/bin/ghostdog match-nvidia-driver grid | ||
| # Otherwise, attempt to load the module. | ||
| ExecStart=/usr/bin/nvidia-smi -q | ||
| # Ensure that the stderr file exists. Otherwise, grep fails on an empty file. | ||
| ExecStart=-/usr/bin/touch /tmp/.nvidia-gridd-license | ||
| # Succeed unless there was a fatal error. | ||
| ExecStart=/usr/bin/grep -Fqvzw Unlicensed /tmp/.nvidia-gridd-license | ||
| RemainAfterExit=true | ||
| StandardOutput=append:/tmp/.nvidia-gridd-license | ||
| Restart=on-failure | ||
| RestartSec=1 | ||
| StartLimitBurst=120 | ||
|
|
||
| [Install] | ||
| RequiredBy=kubelet.service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, will this line actually load the module or are you just generating output that will be
greped later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment might make more sense above the ExecCondition