go: use runtime FIPS instead of compile-time boringcrypto #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes AWS-LC syso file integration from Go toolchains - Updates gofips wrapper to use standard go (no GOEXPERIMENT) - Removes Go binary checks from check-fips macro (Rust only now) - Simplifies musl Go tree creation (no syso file shuffling) FIPS compliance is now controlled at runtime via GODEBUG=fips140=only environment variable rather than compile-time GOEXPERIMENT=boringcrypto. Signed-off-by: Jingwei Wang <[email protected]>
bcressey
reviewed
Jan 7, 2026
| COPY --from=sdk-go-1.25-aws-lc-musl-aarch64 \ | ||
| /home/builder/aws-lc/build/goboringcrypto_linux_arm64.syso \ | ||
| /home/builder/sdk-go/src/crypto/internal/boring/syso/goboringcrypto_linux_musl_arm64.syso | ||
| # FIPS/boringcrypto disabled - skipping aws-lc syso files |
Contributor
There was a problem hiding this comment.
These comments aren't necessary as they refer to code that no longer exists.
| /usr/share/licenses/go-1.24/ | ||
|
|
||
| # Create Go trees for the different glibc and musl builds of the AWS-LC syso. | ||
| # Create Go trees for musl builds (no boringcrypto syso files). |
Contributor
There was a problem hiding this comment.
The different glibc/musl paths shouldn't be necessary any longer. They were added because the syso files end up linked against a libc and consequently have different ABIs, meaning that the Go builds in turn needed to target one or the other.
| COPY --from=sdk-go-1.25-aws-lc-musl-aarch64 \ | ||
| /home/builder/aws-lc/build/goboringcrypto_linux_arm64.syso \ | ||
| /home/builder/sdk-go/src/crypto/internal/boring/syso/goboringcrypto_linux_musl_arm64.syso | ||
| # FIPS/boringcrypto disabled - skipping aws-lc syso files |
Contributor
There was a problem hiding this comment.
This part of the change is incomplete - you're still building AWS-LC and patching the Go sources, you're just not including the syso in the SDK any longer.
You shouldn't end up building AWS-LC after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Description of changes:
This is the minimal change for switching
boringcryptoto runtimeGODEBUG=fips140=only. Will remove the patch and gofips wrapper etc in a separate PR and release.FIPS compliance is now controlled at runtime via GODEBUG=fips140=only environment variable rather than compile-time GOEXPERIMENT=boringcrypto.
Testing done:
Testing with PR1, below showing the
gofipspoint to regular go build.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.