feat: add MPS GPU sharing settings model #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeazelm
force-pushed
the
add_mps
branch
2 times, most recently
from
97fcbc2 to
db7691c
Compare
piyush-jena
approved these changes
Jan 2, 2026
Contributor
piyush-jena
left a comment
piyush-jena
left a comment
There was a problem hiding this comment.
LGTM apart from the nitpicky request for an additional unit test. Nice work coding the conflict between MIG and MPS.
bottlerocket-settings-models/settings-extensions/kubelet-device-plugins/src/lib.rs
Show resolved
Hide resolved
bcressey
reviewed
Jan 9, 2026
bottlerocket-settings-models/settings-extensions/kubelet-device-plugins/src/lib.rs
Outdated
Show resolved
Hide resolved
Add NvidiaMpsSettings struct and Mps variant to NvidiaDeviceSharingStrategy for NVIDIA Multi-Process Service support. Signed-off-by: Matthew Yeazel <[email protected]>
Contributor
Author
|
^ Updated to remove the validation logic which isn't called like I expected it to be. Changed the max to 48 since that is what the device plugin currently enforces. |
bcressey
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bottlerocket-os/bottlerocket#4673
Description of changes:
Add NvidiaMpsSettings struct and Mps variant to NvidiaDeviceSharingStrategy for NVIDIA Multi-Process Service support. Includes validation to prevent MPS and MIG from being enabled simultaneously.
Testing:
The testing was documented in the related PR: bottlerocket-os/bottlerocket-core-kit#789
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.