-
Notifications
You must be signed in to change notification settings - Fork 25
kubernetes: add fail-cgroup-v1 setting #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes: add fail-cgroup-v1 setting #108
Conversation
8845d22 to
181e568
Compare
koooosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to bump the version here, right?
I was planning on doing that in the release PR, but I guess I can make them a single PR given the size of the diffs. |
4b41eff to
4562724
Compare
|
Added changelog and bumped the model versions. |
3b4448c to
7dec72d
Compare
Add fail_cgroup_v1 setting with alias fail-cgroupv1 to match kubelet flag. Signed-off-by: Yutong Sun <yutongsu@amazon.com>
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
7dec72d to
9d90a70
Compare
|
Force pushed to address comments from @KCSesh. Basically added alias to the setting. |
KCSesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Tested the alias - |
Issue #, if available:
bottlerocket-os/bottlerocket#4725
Description of changes:
Add
fail-cgroup-v1setting to support Kubernetes 1.35+ variants.Kubernetes 1.35 enables
failCgroupV1=trueby default in kubelet, causing it to refuse starting on cgroup v1 nodes. While Bottlerocket defaults to cgroup v2, users who have opted into cgroup v1 viasettings.boot.init.systemd.unified_cgroup_hierarchy=0will need a way to override this behavior.This adds a new boolean setting:
This allows users on cgroup v1 to continue running while they plan their migration to cgroup v2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.