feat: add nvidia shared GPU settings to k8s model #49
Closed
monirul wants to merge 1 commit intobottlerocket-os:developfrom
Closed
feat: add nvidia shared GPU settings to k8s model #49monirul wants to merge 1 commit intobottlerocket-os:developfrom
monirul wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
bcressey
reviewed
Aug 8, 2024
monirul
force-pushed
the
timeslicing-changes
branch
2 times, most recently
from
c4db904 to
835cb24
Compare
Contributor
|
The code looks good to me! Do you mind rewriting the git commit message? I'll implement a linter for this, but the settings SDK tends to follow the conventional commit style. You could rewrite the message as: |
monirul
force-pushed
the
timeslicing-changes
branch
2 times, most recently
from
46c41bf to
0478ba2
Compare
monirul
changed the title
cbgbt
reviewed
Aug 9, 2024
monirul
force-pushed
the
timeslicing-changes
branch
2 times, most recently
from
25fe5a2 to
603cc2d
Compare
bcressey
reviewed
Aug 12, 2024
Signed-off-by: Monirul Islam <mamun.sust@gmail.com>
monirul
force-pushed
the
timeslicing-changes
branch
from
603cc2d to
b0c371f
Compare
Contributor
|
Closing in favor of #63. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR introduces two new fields within the
NvidiaDevicePluginSettingsstructure:max_sharing_per_gpuandrename_shared_gpu. These new fields are for managing the timeslicing capabilities of Nvidia GPUs.Setting
max_sharing_per_gputo 1 deactivates time-slicing, effectively disabling GPU sharing. Conversely, a value greater than 1 activates time-slicing, resulting in the creation of the specified number of GPU replicas.The
rename_shared_gpufield dictates the naming convention for shared GPU resources. Afalsevalue retains the original GPU name, whiletruetriggers a renaming process, appending.sharedto the GPU identifier. For instance, enabling this feature would transformnvidia.com/gputonvidia.com/gpu.shared.By contributing this pull request, I grant permission to use, modify, replicate, and distribute my submission, in accordance with your preferred terms.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice."