Skip to content

Conversation

@cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Mar 3, 2025

Description of changes:

  • Upgrade Rust's nightly compiler. This allows us to build against the latest cargo-deny.
  • Modify CI to link against musl to avoid ABI incompatibilities with Bottlerocket's SDK

Testing done:

  • CI on this commit.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: Gavin Inglis <[email protected]>
@cbgbt cbgbt requested review from jmt-lab and sam-berning March 3, 2025 20:43
@cbgbt
Copy link
Contributor Author

cbgbt commented Mar 3, 2025

This pulls in some of the commits developed by @ginglis13 in #467, since he's away for a few days.

@cbgbt cbgbt force-pushed the update-rust-toolchain branch from c5aff50 to 58a1d39 Compare March 5, 2025 18:06
@cbgbt cbgbt changed the title Update rust toolchain to nightly-2025-02-28, Support rustup 1.28.0 Update rust toolchain to nightly-2025-02-28 Mar 5, 2025
@cbgbt
Copy link
Contributor Author

cbgbt commented Mar 5, 2025

This PR originally accommodated breaking changes in rustup 1.28.0; however, upstream fast-followed with 1.28.1 to make the breaking change opt-in.

clarify.toml Outdated
{ path = "LICENSE-APACHE", hash = 0x24b54f4b },
{ path = "LICENSE-MIT", hash = 0x462dee44 },
{ path = "src/unicode/data/LICENSE-UNICODE", hash = 0x70f7339 },
{ path = "src/unicode/data/LICENSE-UNICODE", hash = 0x70f7339 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space:

Suggested change
{ path = "src/unicode/data/LICENSE-UNICODE", hash = 0x70f7339 },
{ path = "src/unicode/data/LICENSE-UNICODE", hash = 0x70f7339 },

ginglis13 and others added 2 commits March 5, 2025 22:17
Update rust toolchain to the latest nightly release. Address lints and
license clarifications as a result.

Signed-off-by: Gavin Inglis <[email protected]>
@cbgbt cbgbt force-pushed the update-rust-toolchain branch from d609600 to bf9c835 Compare March 5, 2025 22:17
@cbgbt cbgbt merged commit 1c96cf1 into bottlerocket-os:develop Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants