Skip to content

Conversation

@cezar-r
Copy link
Contributor

@cezar-r cezar-r commented Dec 18, 2025

Issue number:
#622

Closes #
#622

Description of changes:
Add integration tests for the build-variant and repack-variant make targets in twoliter.

Changes

  • Added new test module variant_build.rs with two integration tests:
    • test_twoliter_build_variant() - validates the complete build-variant workflow (update → fetch → build-variant)
    • test_twoliter_repack_variant() - validates the repack-variant workflow (update → fetch → build-variantrepack-variant)

Testing done:

cargo make test

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt
Copy link
Contributor

cbgbt commented Dec 19, 2025

I think I'd rather see these as E2E tests of twoliter commands rather than direct tests of the scripts themselves. We should be running the twoliter command that rebundles an image with certs.

@cezar-r cezar-r force-pushed the img-integ-tests branch 2 times, most recently from 1a4af89 to 08813bc Compare December 22, 2025 22:36
@cezar-r cezar-r changed the title chore: integration tests for rpm2img and img2img chore: add e2e test for build-variant and repack-variant build targets Dec 22, 2025
@cbgbt cbgbt self-requested a review December 29, 2025 17:53
@cezar-r cezar-r merged commit 2e9e881 into bottlerocket-os:develop Jan 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants