appdata: translate=no properties#3327
Merged
orowith2os merged 1 commit intobottlesdevs:mainfrom Feb 4, 2025
yakushabb:fix-tr
Merged
appdata: translate=no properties#3327orowith2os merged 1 commit intobottlesdevs:mainfrom yakushabb:fix-tr
translate=no properties#3327orowith2os merged 1 commit intobottlesdevs:mainfrom
yakushabb:fix-tr
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
There are several strings from metainfo file appear translatable on Weblate. Could you review this PR when you have time. Thanks. |
Contributor
Pylint result on modfied files: |
1 task
ovari
reviewed
Jan 9, 2025
Contributor
|
I added this to the Bottles 52 milestone, if you want to rebase it. |
It appears that the appstream project no longer supports `translatable=no` properties, and gettext extract the `translatable=no` marked strings as translatable. I opened an issue to inform about the situation, but `translatable=no` properties are not accepted by developers. You can find the issue here: ximion/appstream#623 **Please test your script or string extraction process before merging this PR.** > In MetaInfo files, each individual paragraph of a description > (or enumerated entry) is translated individually, however, > you can only exclude the complete block from being translated > by adding `translate="no"` to the description element. Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html # Description Please include a summary of the change and which issue is fixed (if available). Please also include relevant motivation and context. ## Type of change - [ ] Appdata related chore
TheEvilSkeleton
pushed a commit
that referenced
this pull request
Mar 6, 2025
appdata: translate=no properties It appears that the appstream project no longer supports `translatable=no` properties, and gettext extract the `translatable=no` marked strings as translatable. I opened an issue to inform about the situation, but `translatable=no` properties are not accepted by developers. You can find the issue here: ximion/appstream#623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the appstream project no longer supports
translatable=noproperties, and gettext extract thetranslatable=nomarked strings as translatable.I opened an issue to inform about the situation, but
translatable=noproperties are not accepted by developers. You can find the issue here: ximion/appstream#623Please test your script or string extraction process before merging this PR.
Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
Description
Please include a summary of the change and which issue is fixed (if available).
Please also include relevant motivation and context.
Type of change