Add support for the Dynamic Launcher portal

[ignapk]

Description

This adds support for the xdg-desktop-portal dynamic launcher portal, that will allow to install desktop files without the need for manually giving permission with a command or Flatseal. Upon clicking the Add Desktop Entry option of a wine installed application, the portal will open a dialog where the user can see the app icon, can change the name and confirm or cancel.

Screenshots:

What's missing:
- [ ] Support for [Desktop Action Configure] group in the .desktop file, currently the portal requires exactly one group in the .desktop file for security reasons This is portal limitation, so if wanted, can be done in a follow up MR after adding support for it upstream
- [ ] Requiring xdg-desktop-portal version >= 1.20.1, otherwise doesn't work due to flatpak/xdg-desktop-portal#1674 Modern distributions should have that version already
- [ ] Investigate breakage on GNOME OS, perhaps https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/261 regressed? Can be fixed later

• Rework to delay showing the toast

Fixes #1366

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Build and install locally as specified here https://github.com/bottlesdevs/Bottles/blob/main/CODING_GUIDE.md
• Create a bottle, install an application and create a desktop entry
• Launch the desktop entry from the system app grid

[ignapk]

Closing due to no activity and I see some tasks in the original comment. Tell me if you are still interested since the feature is a good one.

Hi, thanks for looking at it, and to @TheEvilSkeleton for rebasing! About the unmarked tasks in the original comment, how do you feel about skipping the Desktop Action configure, and not requiring xdp >= 1.20.1?

[mirkobrombin]

Closing due to no activity and I see some tasks in the original comment. Tell me if you are still interested since the feature is a good one.

[mirkobrombin]

Not sure how we managed to answer to an old PR almost the same time. Anyway, re-opened.

[ignapk]

Not sure how we managed to answer to an old PR almost the same time. Anyway, re-opened.

I was just getting out of an airplane, maybe some time zone shenanigans 😅

[mirkobrombin]

Oh 👀

[AsciiWolf]

Looks great! Is it also possible to remove the added desktop entries?

[ignapk]

Thanks for review @Borgvall and @mirkobrombin, I've adjusted the MR accordingly, and finished the remaining tasks 😄

[ignapk]

Looks great! Is it also possible to remove the added desktop entries?

The portal API does allow such functionality, however I have not implemented it yet. Perhaps this could be implemented in a follow up MR?

[Borgvall]

The changed commit has resolved all my comments. Thanks @ignapk.

From my point of view, this is ready to be merged.

[mirkobrombin]

Working fine here, thanks for the contribution!

[Simon-Spettmann]

This doesn't work in some cases, see #4402. I am unfamiliar with the code base, but I can provide more information if that helps someone to figure out what the problem is.

[ignapk]

This doesn't work in some cases, see #4402. I am unfamiliar with the code base, but I can provide more information if that helps someone to figure out what the problem is.

Thanks for letting us know, let's keep discussing it in #4402 :)