Download manager #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberphantom52
force-pushed
the
download_manager
branch
from
14ed8ed to
3ff5768
Compare
cyberphantom52
force-pushed
the
download_manager
branch
2 times, most recently
from
bfe7bb1 to
1a84e58
Compare
- Also Re-Queue requests on retry
cyberphantom52
force-pushed
the
download_manager
branch
from
1a84e58 to
3f0f476
Compare
|
This can be merged as is after being reviewed, and the pending items from the checklist can be implemented as follow up MRs. What i want is for reviewers to review the design of the entire download flow and watch out for concurrency bugs which i tried to avoid as much as possible but some might have snuck in anyways. Also i did some basic testing but this needs to be properly tested. |
8 tasks
We now use proper queues instead of channels for downloads so we don't need to configure this
cyberphantom52
force-pushed
the
download_manager
branch
from
6bb4036 to
ca16f1f
Compare
mirkobrombin
approved these changes
Sep 2, 2025
- Also make cancellations more responsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO List: