Skip to content

C is never used? #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kornelski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

C is never used? #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions misc/ok_color.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#pragma once
// Copyright(c) 2021 Bj�rn Ottosson
// Copyright(c) 2021 Björn Ottosson
//
// Permission is hereby granted, free of charge, to any person obtaining a copy of
// this softwareand associated documentation files(the "Software"), to deal in
Expand Down Expand Up @@ -667,10 +667,7 @@ HSV srgb_to_okhsv(RGB rgb)
RGB rgb_scale = oklab_to_linear_srgb({ L_vt, a_ * C_vt, b_ * C_vt });
float scale_L = cbrtf(1.f / fmax(fmax(rgb_scale.r, rgb_scale.g), fmax(rgb_scale.b, 0.f)));

L = L / scale_L;
C = C / scale_L;

C = C * toe(L) / L;
L = L / scale_L;
L = toe(L);

// we can now compute v and s:
Expand All @@ -681,4 +678,4 @@ HSV srgb_to_okhsv(RGB rgb)
return { h, s, v };
}

} // namespace ok_color
} // namespace ok_color