Open
Conversation
Needs to be added to braginskii_conduction which is now separate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new flag
diagnose_termswhich saves each term in the pressure equation as a separate diagnostic.This is the first instance of an extra diagnostics flag in the code because it introduces a lot of new variables. Is this the right approach, or shall we have a more generic
diagnose_extraor something like this, which would enable a generic extra level of diagnostics?I also improved the convention for the sources diagnostic. In this PR, there is a distinct
component_sourceanduser_source. The former is a source term from other components, e.g. reactions. The latter is the user-set source.So, two questions:
diagnose_terms, or maybe by a more genericdiagnose_extrato act as the 2nd diagnostics level?todo:
evolve_pressurebraginskii-conduction