Conversation
…er density and pressure from grid variables with names varName_init. fixed_density and isothermal: Added a functionality to read the fixed denstiy or temperature from grid variables with names varName_init
…mponents. This willbe needed in neutral_mixed for calculating the contribution of the ion velocity.
…perpendicular velocity to make it consistent with AFN models.
…the perpendicular and parallel directions. This is what they do in UEDGE as well. -Added the contibution of ion velocities to the neural diffusion perpendicular velocity. This term comes form momentum source terms due to collisions of neutrals with ions. See eq 20 amd 21 of Horsten 2017.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 26.41% 26.27% -0.15%
==========================================
Files 90 90
Lines 8105 8221 +116
Branches 1133 1146 +13
==========================================
+ Hits 2141 2160 +19
- Misses 5745 5836 +91
- Partials 219 225 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for this @malamast. My own re-implementation of this (mikekryjak#15) has been hopelessly delayed by several conferences and an unrelated paper. These are now done so I will be moving onto this soon. I need to compare the performance of these limiters against my SOLPS and SOLEDGE2D results. I can also implement some unit tests. |
Hi Mike. Sounds good. Sorry, I hadn't seen your pull request. Maybe we could try to merge the changes in the two PRs together. |
|
I'm happy to deal with it - I need this to finish my ST40 comparison and paper. |
Just a few suggestions for neutral_mixed and other components: