Skip to content

Add 3 extra iterations in findIndex#57

Open
dschwoerer wants to merge 1 commit intomasterfrom
fix-findIndex
Open

Add 3 extra iterations in findIndex#57
dschwoerer wants to merge 1 commit intomasterfrom
fix-findIndex

Conversation

@dschwoerer
Copy link
Collaborator

That seems to push the error down to 1e-28.

Resolves #56

That seems to push the error down to 1e-28.
@ZedThree
Copy link
Member

ZedThree commented Feb 2, 2026

Is this not just equivalent to reducing the tolerance? Could we just make the default 1e-15 or something?

@dschwoerer
Copy link
Collaborator Author

It seems to be equivalent to reducing it to around 1e-27.
But I am worried that it makes it fail for other cases.
But we could set it to that, and wait for users complaining?

@ZedThree
Copy link
Member

ZedThree commented Feb 2, 2026

That seems like overkill to me, is that what's required to resolve #56? Is the issue with #56 that this tolerance is not a setting exposed to the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tolerances in findIndex

2 participants