fix: handle GitHub API errors gracefully in 'info --versions' #2357
+50
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Julian Ready for review! Please take a look. |
Member
|
I've seen this PR but I don't want any use of mocks in tests. I haven't had time to look more closely at suggesting what you can use instead, but that's what this is blocked on FYI! |
Contributor
Author
|
Understood. Whenever you have a suggestion for the testing pattern, I'm happy to update the code. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1519
Problem
Previously, running
bowtie info --versionswould crash with a traceback if the GitHub API request failed due to missing authentication tokens.Solution
I've wrapped the GitHub API iteration in
_core.pywithsuppress(GitHubError). Now, if the API call fails, Bowtie gracefully skips the remote version tags and displays the rest of the implementation info using the locally available version data.Testing
Added
tests/test_info_versions.pywhich mocks the GitHub client and forces aGitHubErrorto verify that the function returns the fallback version instead of raising an exception.