add working jsu-compile based bowtie with C backend#2455
Open
zx80 wants to merge 8 commits intobowtie-json-schema:mainfrom
Open
add working jsu-compile based bowtie with C backend#2455zx80 wants to merge 8 commits intobowtie-json-schema:mainfrom
zx80 wants to merge 8 commits intobowtie-json-schema:mainfrom
Conversation
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
Julian
reviewed
Mar 10, 2026
Julian
reviewed
Mar 10, 2026
Julian
reviewed
Mar 10, 2026
5232aa9 to
2326fa8
Compare
added 6 commits
March 12, 2026 09:59
for more information, see https://pre-commit.ci
Author
|
I think I've done what you asked. If this is okay, I'll also submit the version for Perl, Java and JavaScript, either as one submission or 3, as your wish. |
Member
|
I actually am on vacation so I hadn't seen your response (nor rereviewed the PR) -- it's possible I misunderstood the intention and gave wrong feedback, I was assuming this new harness could subsume the old one, but if indeed you think it's worth running the implementation differently then it's all fine to keep separate. I'll have another review when I'm back from vacation.
One is fine! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to add the different jsu compiler backends, this is the first with the C backend,
I have also working harnesses for js, java and perl which share the same script to run the commands but distinct containers to provide the appropriate runtime. There may also be one later for PL/pgSQL, which requires more wrapping. I'm planning to submit the other ones once your are happy with the common harness script.
In theory, the result should be the same as the
python-jsu, in practice, there may be minutes differences due to backend bugs or limitations, hence the point of adding them as well.