-
Notifications
You must be signed in to change notification settings - Fork 0
[pre-commit.ci] pre-commit autoupdate (add zizmor config to allow ref-pinned actions) #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0b5ef5
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] 61f1dc1
add idea files to gitignore
OptimumCode 7d03944
correct zizmor url due to migration in 1.8.0
OptimumCode 4914dd1
add zizmor configuration to allow ref-pin actions
OptimumCode 777480c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,7 @@ build | |
| gradle/wrapper | ||
| gradlew | ||
| gradlew.bat | ||
|
|
||
| # IDEA | ||
| .idea | ||
| out/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| rules: | ||
| unpinned-uses: | ||
| config: | ||
| policies: | ||
| actions/*: ref-pin | ||
| "*": ref-pin |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Julian, would you be okay with that solution? (I don't see any point in having hash-pin actions in harnesses repo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the point is the same as "usual" no? I.e. it prevents vulnerabilities due to third party actions getting hacked. E.g. a scenario is:
All of which isn't to say I'm fine with handling this later if need be, there are many places where we do this already (because I wasn't aware of how it could be an issue until zizmor reminded me)
So yeah feel free to merge of course!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did not consider this point (I will take a look at pinning actions to hashes - at least those that build docker image)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to point it out (since it wasn't obvious to me either!) dependabot will happily still keep the hash up to date. So actually another thing for us to consider if we're already considering this threat mode is that we should potentially not automerge github action bump PRs (and only do so for the implementation itself)?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the problem (I think, at least, this is a problem) is that we have dependabot that updates actions automatically and not review happens - so, it looks like, there is no difference from having ref pinned actions like we do right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be a lot of work once we move all the test harnesses out of the bowtie repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I don't think we will be able to handle that amount of work across all the repositories (since the frequency of updates for hash-pinned actions will be much higher than right now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can, probably, try that at least, and if we see that it does not work for us, go back to the ref-pinned actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that dependabot adds labels to PRs which says what it is bumping -- so I think it should be as "simple" as ignoring PRs with the
githublabel in automerge? Maybe?? But yeah I'm good with whatever certainly in the short term!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that part should be simple. But then we need to find time to review that update (and this part might not be that simple once we move other harnesses to separate repos).
In any case, I will try to create a PR for that, merge it and then we will see whether it works for us or not