Skip to content

feat(media): add fullscreen keyboard shortcut to React controls#1605

Open
ittaishay wants to merge 1 commit intobox:masterfrom
ittaishay:feat/fullscreen-keyboard-shortcut
Open

feat(media): add fullscreen keyboard shortcut to React controls#1605
ittaishay wants to merge 1 commit intobox:masterfrom
ittaishay:feat/fullscreen-keyboard-shortcut

Conversation

@ittaishay
Copy link

@ittaishay ittaishay commented Feb 3, 2026

Summary

Adds the 'f' keyboard shortcut to toggle fullscreen mode in the React video controls (handleKeydownReact), matching the existing behavior in the legacy controls (handleKeydown).

Changes

  • Added f and shift+f key handlers to handleKeydownReact in MediaBaseViewer.js
  • Added corresponding unit tests in MediaBaseViewer-test.js

Background

The video player has two keyboard handling paths:

  • Legacy controls (handleKeydown) - already supported 'f' for fullscreen
  • React controls (handleKeydownReact) - was missing this shortcut

This PR brings parity between the two by adding the fullscreen shortcut to the React controls path.

Test Plan

  • Press 'f' while viewing a video with React controls enabled - should toggle fullscreen
  • Press 'Shift+F' while viewing a video - should also toggle fullscreen
  • Verify existing keyboard shortcuts still work (space/k for play/pause, arrow keys for seek, m for mute, etc.)

@ittaishay ittaishay requested a review from a team as a code owner February 3, 2026 00:24
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ittai Shay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

sanilsalvi added a commit to sanilsalvi/box-content-preview that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants