Skip to content

feat: Enforce exact byte reading from Content-Length header for BoxFile representation #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abdulhaleem wants to merge 5 commits into from
Closed

feat: Enforce exact byte reading from Content-Length header for BoxFile representation #1273

abdulhaleem wants to merge 5 commits into from

Conversation

@abdulhaleem
Copy link

@abdulhaleem abdulhaleem commented Nov 18, 2024 •
edited
Loading

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #4144

Details

  • 19 of 26 (73.08%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 71.77%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BinaryBodyUtils.java 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #4125: 0.007%
Covered Lines: 8067
Relevant Lines: 11240
💛 - Coveralls

@abdulhaleem abdulhaleem force-pushed the track-data-streaming-bytes branch from 7cfe00e to 53952d1 Compare November 20, 2024 17:35
@abdulhaleem abdulhaleem force-pushed the track-data-streaming-bytes branch from 91e9ca7 to b7dee6d Compare November 20, 2024 17:38
@abdulhaleem abdulhaleem changed the title feat: Tracking the bytes in output stream from representation service… feat: Track bytes in rep service output stream Nov 20, 2024
lukaszsocha2
lukaszsocha2 reviewed Nov 21, 2024
View reviewed changes
lukaszsocha2
lukaszsocha2 reviewed Nov 21, 2024
View reviewed changes
lukaszsocha2
lukaszsocha2 reviewed Nov 21, 2024
View reviewed changes
lukaszsocha2
lukaszsocha2 reviewed Nov 21, 2024
View reviewed changes
@lukaszsocha2 lukaszsocha2 changed the title feat: Track bytes in rep service output stream feat: Enforce exact byte reading from Content-Length header for BoxFile representation Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abdulhaleem @CLAassistant @coveralls @lukaszsocha2