fix: Correctly calculate Content-Length when reading from a stream
#1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #4180Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #4177Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #4219Details
💛 - Coveralls |
abdulhaleem
reviewed
Nov 27, 2024
| private static long getContentLengthFromAPIResponse(BoxAPIResponse response) { | ||
| long length = response.getContentLength(); | ||
| try { | ||
| if (length == -1 && response.getHeaders().containsKey(X_ORIGINAL_CONTENT_LENGTH)) { |
There was a problem hiding this comment.
The code on line 93 checks for the size of the body, could you add one more checked please here
for the header response.getHeaders().containsKey(HttpHeaders.CONTENT_LENGTH) as well please. Basically,
- Check for response.getContentLength()
- Check for response.getHeaders().containsKey(HttpHeaders.CONTENT_LENGTH)
- Check for response.getHeaders().containsKey(X_ORIGINAL_CONTENT_LENGTH)
arjankowski
force-pushed
the
aj/fix-content-length-check
branch
from
0153e0c to
8d71339
Compare
abdulhaleem
approved these changes
Nov 27, 2024
arjankowski
force-pushed
the
aj/fix-content-length-check
branch
from
365a523 to
6c742ca
Compare
arjankowski
force-pushed
the
aj/fix-content-length-check
branch
from
6c742ca to
f08074a
Compare
lukaszsocha2
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.