fix: leverage shared_link_permission_options instead

reneshen0328 · reneshen0328 · commit adeb1d0300b9 · 2026-03-04T13:18:33.000-08:00
diff --git a/src/constants.js b/src/constants.js
@@ -124,6 +124,7 @@ export const FIELD_SHARED_LINK_ACCESS_LEVELS_DISABLED_REASONS: 'allowed_shared_l
 export const FIELD_SHARED_LINK_FEATURES: 'shared_link_features' = 'shared_link_features';
 export const FIELD_ALLOWED_INVITEE_ROLES: 'allowed_invitee_roles' = 'allowed_invitee_roles';
 export const FIELD_ALLOWED_SHARED_LINK_ACCESS_LEVELS = 'allowed_shared_link_access_levels';
+export const FIELD_SHARED_LINK_PERMISSION_OPTIONS: 'shared_link_permission_options' = 'shared_link_permission_options';
 export const FIELD_HAS_COLLABORATIONS = 'has_collaborations';
 export const FIELD_IS_EXTERNALLY_OWNED = 'is_externally_owned';
 export const FIELD_TOTAL_COUNT = 'total_count';
diff --git a/src/elements/content-sharing/constants.js b/src/elements/content-sharing/constants.js
@@ -1,3 +1,19 @@
+import {
+    FIELD_ALLOWED_INVITEE_ROLES,
+    FIELD_ALLOWED_SHARED_LINK_ACCESS_LEVELS,
+    FIELD_CLASSIFICATION,
+    FIELD_DESCRIPTION,
+    FIELD_EXTENSION,
+    FIELD_ID,
+    FIELD_NAME,
+    FIELD_OWNED_BY,
+    FIELD_PERMISSIONS,
+    FIELD_SHARED_LINK,
+    FIELD_SHARED_LINK_ACCESS_LEVELS_DISABLED_REASONS,
+    FIELD_SHARED_LINK_FEATURES,
+    FIELD_SHARED_LINK_PERMISSION_OPTIONS,
+    FIELD_TYPE as FIELD_ITEM_TYPE,
+} from '../../constants';
 import {
     CLASSIFICATION_COLOR_ID_0,
     CLASSIFICATION_COLOR_ID_1,
@@ -18,21 +34,6 @@ import {
     bdlWatermelonRed50,
     bdlYellow50,
 } from '../../styles/variables';
-import {
-    FIELD_ALLOWED_INVITEE_ROLES,
-    FIELD_ALLOWED_SHARED_LINK_ACCESS_LEVELS,
-    FIELD_CLASSIFICATION,
-    FIELD_EXTENSION,
-    FIELD_DESCRIPTION,
-    FIELD_ID,
-    FIELD_NAME,
-    FIELD_OWNED_BY,
-    FIELD_PERMISSIONS,
-    FIELD_SHARED_LINK,
-    FIELD_SHARED_LINK_ACCESS_LEVELS_DISABLED_REASONS,
-    FIELD_SHARED_LINK_FEATURES,
-    FIELD_TYPE as FIELD_ITEM_TYPE,
-} from '../../constants';
 
 export const CONTENT_SHARING_ERRORS = {
     400: 'badRequestError',
@@ -56,6 +57,7 @@ export const CONTENT_SHARING_ITEM_FIELDS = [
     FIELD_SHARED_LINK,
     FIELD_SHARED_LINK_ACCESS_LEVELS_DISABLED_REASONS,
     FIELD_SHARED_LINK_FEATURES,
+    FIELD_SHARED_LINK_PERMISSION_OPTIONS,
 ];
 
 export const CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS = {
diff --git a/src/elements/content-sharing/types.js b/src/elements/content-sharing/types.js
@@ -2,6 +2,8 @@
 import type { CollaborationRole, Collaborator, DateValue, Item, SharedLink } from '@box/unified-share-modal';
 
 import API from '../../api';
+
+import type { RequestOptions } from '../../common/types/api';
 import type {
     Access,
     BoxItemClassification,
@@ -20,7 +22,6 @@ import type {
     item,
     sharedLinkType as USMSharedLinkType,
 } from '../../features/unified-share-modal/flowTypes';
-import type { RequestOptions } from '../../common/types/api';
 
 // "SLS" denotes values that are used in the Shared Link Settings modal
 type ContentSharingEnterpriseDataType = {
@@ -88,6 +89,7 @@ export type ContentSharingItemAPIResponse = {
         password: boolean,
         vanity_name: boolean,
     },
+    shared_link_permission_options?: Array<'can_preview' | 'can_download' | 'can_edit'>,
     type: ItemType,
 };
 
diff --git a/src/elements/content-sharing/utils/__mocks__/ContentSharingV2Mocks.js b/src/elements/content-sharing/utils/__mocks__/ContentSharingV2Mocks.js
@@ -110,6 +110,7 @@ export const DEFAULT_ITEM_API_RESPONSE = {
     permissions: MOCK_PERMISSIONS,
     shared_link: null,
     shared_link_features: { password: true },
+    shared_link_permission_options: ['can_edit', 'can_download', 'can_preview'],
     type: MOCK_ITEM.type,
 };
 
diff --git a/src/elements/content-sharing/utils/__tests__/convertItemResponse.test.ts b/src/elements/content-sharing/utils/__tests__/convertItemResponse.test.ts
@@ -6,6 +6,7 @@ import {
     mockOwnerId,
     mockOwnerName,
 } from '../__mocks__/ContentSharingV2Mocks';
+
 import { convertItemResponse } from '../convertItemResponse';
 import { getAllowedPermissionLevels } from '../getAllowedPermissionLevels';
 
@@ -30,8 +31,8 @@ describe('convertItemResponse', () => {
                 { id: 'viewer', isDefault: false },
             ],
             item: {
-                id: '123456789',
                 classification: undefined,
+                id: '123456789',
                 name: 'Box Development Guide.pdf',
                 permissions: {
                     canInviteCollaborator: true,
@@ -80,7 +81,7 @@ describe('convertItemResponse', () => {
                 accessLevels: ['open', 'company', 'collaborators'],
                 expiresAt: 1704067200000,
                 permission: 'can_download',
-                permissionLevels: ['canDownload', 'canPreview'],
+                permissionLevels: ['can_edit', 'can_download', 'can_preview'],
                 settings: {
                     canChangeDownload: true,
                     canChangeExpiration: true,
@@ -97,20 +98,19 @@ describe('convertItemResponse', () => {
             });
         });
 
-        test('should pass extension to getAllowedPermissionLevels', () => {
-            const MOCK_ITEM_WITH_EXTENSION = {
+        test('should use shared_link_permission_options from API when available', () => {
+            const result = convertItemResponse(MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK);
+            expect(result.sharedLink?.permissionLevels).toEqual(['can_edit', 'can_download', 'can_preview']);
+            expect(getAllowedPermissionLevels).not.toHaveBeenCalled();
+        });
+
+        test('should call getAllowedPermissionLevels when shared_link_permission_options is not available', () => {
+            const mockItemWithoutPermissionOptions = {
                 ...MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK,
-                extension: 'pdf',
+                shared_link_permission_options: undefined,
             };
-            convertItemResponse(MOCK_ITEM_WITH_EXTENSION);
-            expect(getAllowedPermissionLevels).toHaveBeenCalledWith({
-                access: 'open',
-                canChangeAccessLevel: true,
-                extension: 'pdf',
-                isDownloadSettingAvailable: true,
-                itemType: 'file',
-                permission: 'can_download',
-            });
+            convertItemResponse(mockItemWithoutPermissionOptions);
+            expect(getAllowedPermissionLevels).toHaveBeenCalledWith(true, true, 'can_download');
         });
 
         test('should convert shared link settings correctly if user cannot change access level', () => {
diff --git a/src/elements/content-sharing/utils/__tests__/getAllowedPermissionLevels.test.ts b/src/elements/content-sharing/utils/__tests__/getAllowedPermissionLevels.test.ts
@@ -1,72 +1,29 @@
-import {
-    ACCESS_OPEN,
-    PERMISSION_CAN_DOWNLOAD,
-    PERMISSION_CAN_EDIT,
-    PERMISSION_CAN_PREVIEW,
-    TYPE_FILE,
-} from '../../../../constants';
+import { PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW } from '../../../../constants';
 
 import { getAllowedPermissionLevels } from '../getAllowedPermissionLevels';
 
 describe('getAllowedPermissionLevels', () => {
-    const defaultParams = {
-        access: ACCESS_OPEN,
-        canChangeAccessLevel: true,
-        extension: 'pdf',
-        isDownloadSettingAvailable: true,
-        itemType: TYPE_FILE,
-        permission: PERMISSION_CAN_DOWNLOAD,
-    };
-
-    test('should return all permission levels when all conditions are met', () => {
-        const result = getAllowedPermissionLevels(defaultParams);
-        expect(result).toEqual([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT]);
+    test('should return both permission levels when all conditions are met', () => {
+        const result = getAllowedPermissionLevels(true, true, PERMISSION_CAN_DOWNLOAD);
+        expect(result).toEqual([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW]);
     });
 
-    test.each([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT])(
+    test.each([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW])(
         'should return only current permission when cannot change access level',
         permission => {
-            const result = getAllowedPermissionLevels({
-                ...defaultParams,
-                canChangeAccessLevel: false,
-                permission,
-            });
+            const result = getAllowedPermissionLevels(false, true, permission);
             expect(result).toEqual([permission]);
         },
     );
 
     test('should exclude download permission when download setting is not available', () => {
-        const result = getAllowedPermissionLevels({
-            ...defaultParams,
-            isDownloadSettingAvailable: false,
-        });
-        expect(result).toEqual([PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT]);
+        const result = getAllowedPermissionLevels(true, false, PERMISSION_CAN_DOWNLOAD);
+        expect(result).toEqual([PERMISSION_CAN_PREVIEW]);
     });
 
     test('should return empty array for unknown permission values when cannot change access level', () => {
-        const result = getAllowedPermissionLevels({
-            ...defaultParams,
-            canChangeAccessLevel: false,
-            permission: 'unknown_permission',
-        });
+        const unknownPermission = 'unknown_permission';
+        const result = getAllowedPermissionLevels(false, true, unknownPermission);
         expect(result).toEqual([]);
     });
-
-    test.each([
-        [true, true, PERMISSION_CAN_PREVIEW],
-        [true, true, PERMISSION_CAN_DOWNLOAD],
-        [false, true, PERMISSION_CAN_PREVIEW],
-    ])(
-        'should exclude edit permission for webdocs when canChangeAccessLevel=%s, isDownloadSettingAvailable=%s, permission=%s',
-        (canChangeAccessLevel, isDownloadSettingAvailable, permission) => {
-            const result = getAllowedPermissionLevels({
-                ...defaultParams,
-                canChangeAccessLevel,
-                extension: 'webdoc',
-                isDownloadSettingAvailable,
-                permission,
-            });
-            expect(result).not.toContain(PERMISSION_CAN_EDIT);
-        },
-    );
 });
diff --git a/src/elements/content-sharing/utils/convertItemResponse.ts b/src/elements/content-sharing/utils/convertItemResponse.ts
@@ -1,4 +1,5 @@
-import { ACCESS_COLLAB, INVITEE_ROLE_EDITOR, PERMISSION_CAN_DOWNLOAD } from '../../../constants';
+import { ACCESS_COLLAB, INVITEE_ROLE_EDITOR, PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_EDIT } from '../../../constants';
+
 import { API_TO_USM_CLASSIFICATION_COLORS_MAP } from '../constants';
 import { getAllowedAccessLevels } from './getAllowedAccessLevels';
 import { getAllowedPermissionLevels } from './getAllowedPermissionLevels';
@@ -11,13 +12,13 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
         allowed_shared_link_access_levels,
         allowed_shared_link_access_levels_disabled_reasons,
         classification,
-        extension,
         id,
         name,
         owned_by: ownedBy,
         permissions,
         shared_link,
         shared_link_features,
+        shared_link_permission_options,
         type,
     } = itemApiData;
 
@@ -55,7 +56,7 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
             vanity_url: vanityUrl,
         } = shared_link;
 
-        const isDownloadAllowed = permission === PERMISSION_CAN_DOWNLOAD;
+        const isDownloadAllowed = permission === PERMISSION_CAN_DOWNLOAD || permission === PERMISSION_CAN_EDIT;
         const canChangeDownload = canChangeAccessLevel && isDownloadSettingAvailable && access !== ACCESS_COLLAB; // access must be "company" or "open"
         const canChangePassword = canChangeAccessLevel && isPasswordAvailable;
         const canChangeExpiration = canChangeAccessLevel && isEditAllowed;
@@ -68,14 +69,9 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
             ),
             expiresAt: expirationTimestamp ? new Date(expirationTimestamp).getTime() : undefined, // convert to milliseconds
             permission,
-            permissionLevels: getAllowedPermissionLevels({
-                access,
-                canChangeAccessLevel,
-                extension,
-                isDownloadSettingAvailable,
-                itemType: type,
-                permission,
-            }),
+            permissionLevels:
+                shared_link_permission_options ??
+                getAllowedPermissionLevels(canChangeAccessLevel, isDownloadSettingAvailable, permission),
             settings: {
                 canChangeDownload,
                 canChangeExpiration,
@@ -100,8 +96,8 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
     return {
         collaborationRoles,
         item: {
-            id,
             classification: classificationData,
+            id,
             name,
             permissions: {
                 canInviteCollaborator: !!canInvite,
@@ -110,13 +106,13 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
             },
             type,
         },
+        ownedBy,
         sharedLink,
         sharingService: {
             can_set_share_access: canChangeAccessLevel,
             can_share: canShare,
             ownerEmail: ownedBy.login,
             ownerId: ownedBy.id,
         },
-        ownedBy,
     };
 };
diff --git a/src/elements/content-sharing/utils/convertSharingServiceData.ts b/src/elements/content-sharing/utils/convertSharingServiceData.ts
@@ -13,6 +13,7 @@ export interface ConvertSharedLinkSettingsReturnType {
     password?: string | null;
     permissions?: {
         can_download?: boolean;
+        can_edit?: boolean;
         can_preview: boolean;
     };
     unshared_at: string | null;
diff --git a/src/elements/content-sharing/utils/getAllowedPermissionLevels.ts b/src/elements/content-sharing/utils/getAllowedPermissionLevels.ts
@@ -1,30 +1,11 @@
-import {
-    ACCESS_COMPANY,
-    ACCESS_OPEN,
-    PERMISSION_CAN_DOWNLOAD,
-    PERMISSION_CAN_EDIT,
-    PERMISSION_CAN_PREVIEW,
-    TYPE_FOLDER,
-} from '../../../constants';
+import { PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW } from '../../../constants';
 
-type GetAllowedPermissionLevelsParams = {
-    access: string;
-    canChangeAccessLevel: boolean;
-    extension: string;
-    isDownloadSettingAvailable: boolean;
-    itemType: string;
-    permission: string;
-};
-
-export const getAllowedPermissionLevels = ({
-    access,
+export const getAllowedPermissionLevels = (
     canChangeAccessLevel,
-    extension,
     isDownloadSettingAvailable,
-    itemType,
     permission,
-}: GetAllowedPermissionLevelsParams): Array<string> => {
-    let allowedPermissionLevels = [PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT];
+): Array<string> => {
+    let allowedPermissionLevels = [PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW];
 
     if (!canChangeAccessLevel) {
         // remove all but current level
@@ -36,11 +17,5 @@ export const getAllowedPermissionLevels = ({
         allowedPermissionLevels = allowedPermissionLevels.filter(level => level !== PERMISSION_CAN_DOWNLOAD);
     }
 
-    // Can Edit requires ACCESS_OPEN or ACCESS_COMPANY, and must NOT be a folder
-    const canEditAccessLevels = [ACCESS_OPEN, ACCESS_COMPANY];
-    if (!canEditAccessLevels.includes(access) || itemType === TYPE_FOLDER || extension?.toLowerCase() === 'webdoc') {
-        allowedPermissionLevels = allowedPermissionLevels.filter(level => level !== PERMISSION_CAN_EDIT);
-    }
-
     return allowedPermissionLevels;
 };
