fix: Fix configure:environments:set-current command#568
Merged
arjankowski merged 1 commit intomainfrom Mar 5, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 13676124578Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes setting current environment.
Previously
configure:environment:set-currentwasn't work because bad parameter was used internally.Instead using
args.idtheargs.namewas used which was had unassigned value. As a result, even if the user passed the value, it wasn't detected and user had to choose env from the list.The second issue was with adding new environment via
configure:environment:addcommand and settingset-as-currentflag.To set created environment as a current we have to save it to environmentsObject and store this by using
await this.updateEnvironments(environmentsObj), like we do in set-current.