-
Notifications
You must be signed in to change notification settings - Fork 64
chore: setup prettier for code formatting and eslint
#605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f94d284 to
5aa1606
Compare
5aa1606 to
1fbd146
Compare
| ARGUMENTS | ||
| NAME The user's name | ||
| LOGIN The user's email address, not required when creating app users | ||
| NAME The user's name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct that for instance the LOGIN argument was put into brackets [LOGIN] but NAME wasn't?
why is the wrapping rule in brackets not consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have name is required but not for login:
UsersCreateCommand.args = {
name: Args.string({
name: 'name',
required: true,
hidden: false,
description: "The user's name",
}),
login: Args.string({
name: 'login',
required: false,
hidden: false,
description:
"The user's email address, not required when creating app users",
}),
};
db0f4ba to
dbfb8cd
Compare
|
Why cant we use dynamic import for some of the esm modules to avoid the warnings? |
prettier for code formatting and eslint
|
Hi @Hawra2020 The warning we have it's about linting issue but as we are using CJS, we are not able to use import for now :( |
Pask423
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem like mostly formatting changes, LGTM
In this PR: