Skip to content

Conversation

@congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Oct 31, 2025

In this PR:

  • Generated docs from oclif library
  • Removed all the manual ESLint rule, replace with the recommended from eslint library.
  • Setup prettier and format it

@congminh1254 congminh1254 force-pushed the update-eslint-prettier branch from f94d284 to 5aa1606 Compare October 31, 2025 12:02
@congminh1254 congminh1254 force-pushed the update-eslint-prettier branch from 5aa1606 to 1fbd146 Compare October 31, 2025 12:05
Percival33
Percival33 previously approved these changes Oct 31, 2025
ARGUMENTS
NAME The user's name
LOGIN The user's email address, not required when creating app users
NAME The user's name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that for instance the LOGIN argument was put into brackets [LOGIN] but NAME wasn't?
why is the wrapping rule in brackets not consistent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have name is required but not for login:

UsersCreateCommand.args = {
	name: Args.string({
		name: 'name',
		required: true,
		hidden: false,
		description: "The user's name",
	}),
	login: Args.string({
		name: 'login',
		required: false,
		hidden: false,
		description:
			"The user's email address, not required when creating app users",
	}),
};

@congminh1254 congminh1254 force-pushed the update-eslint-prettier branch from db0f4ba to dbfb8cd Compare October 31, 2025 13:37
@Hawra2020
Copy link
Contributor

Why cant we use dynamic import for some of the esm modules to avoid the warnings?

@congminh1254 congminh1254 changed the title chore: Format code and eslint chore: setup prettier for code formatting and eslint Oct 31, 2025
@congminh1254
Copy link
Member Author

Hi @Hawra2020

The warning we have it's about linting issue but as we are using CJS, we are not able to use import for now :(

Hawra2020
Hawra2020 previously approved these changes Oct 31, 2025
Copy link
Collaborator

@Pask423 Pask423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like mostly formatting changes, LGTM

@congminh1254 congminh1254 merged commit 0dffced into main Oct 31, 2025
13 checks passed
@congminh1254 congminh1254 deleted the update-eslint-prettier branch October 31, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants